Skip to content

Fix interact outside false positive #3935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2023
Merged

Fix interact outside false positive #3935

merged 2 commits into from
Jan 19, 2023

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Jan 19, 2023 •
edited
Loading

Closes #3933

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Go to the docs useModalOveraly page, follow steps outlined in Issue that this PR closes

🧢 Your Project:

@rspbot
Copy link

rspbot commented Jan 19, 2023

Build successful! 🎉

reidbarber
reidbarber approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not able to reproduce issue

@rspbot
Copy link

rspbot commented Jan 19, 2023

Build successful! 🎉

@rspbot
Copy link

rspbot commented Jan 19, 2023

## API Changes

unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }

LFDanLu
LFDanLu approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snowystinger snowystinger merged commit 44b90ef into main Jan 19, 2023
@snowystinger snowystinger deleted the fix-interact-outside-false-positive branch January 19, 2023 23:03
@LFDanLu LFDanLu mentioned this pull request Feb 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbarber reidbarber reidbarber approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dismissible dialog drag in+drag out dismisses
4 participants
@snowystinger @rspbot @reidbarber @LFDanLu